[HttpKernel] Remove always-true condition on existence of DI Autowire class
#60079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in symfony#45657 symfony/dependency-injection 6.4+ is required, so the class always exists
kbond
approved these changes
Mar 28, 2025
GromNaN
commented
Mar 28, 2025
| @@ -129,7 +127,7 @@ public function process(ContainerBuilder $container): void | |||
| /** @var \ReflectionParameter $p */ | |||
| $type = preg_replace('/(^|[(|&])\\\\/', '\1', $target = ltrim(ProxyHelper::exportType($p) ?? '', '?')); | |||
| $invalidBehavior = ContainerInterface::IGNORE_ON_INVALID_REFERENCE; | |||
| $autowireAttributes = $autowire ? $emptyAutowireAttributes : []; | |||
| $autowireAttributes = null; | |||
There was a problem hiding this comment.
The variable $autowireAttributes is used in 1 place when $autowire is true. But still need to be reset on each loop.
|
For 7.2? |
That's a minor cleanup, not a bug. So I think the rule is to merge into 7.3. |
chalasr
approved these changes
Mar 28, 2025
mtarld
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This condition was introduced in #45657
The class
RegisterControllerArgumentLocatorsPassrequires the DI component, which cannot be < 6.4 due to a conflict rule in composer.json. So theAutoconfigureclass always exists.