moved most static assets directly into the templates #6006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the images blue_picto_more and blue_picto_less are also used in DoctrineBundle (and probably in JMSDebuggingBundle but I haven't checked). Could you submit a PR inlining the images too before removing them ? |
|
Any image useful for other bundles should not be deleted. So, if DoctrineBundle is using the blue_pico_* images, I'm going to revert their deletion. |
|
I'm using them in two bundles, JMSDebuggingBundle and JMSJobQueueBundle (same for the exception related templates). |
|
Wouldn't it be better to have the encoded icons in a separate CSS file as different classes/background images? |
This has been done for several reasons: * for consistency with the way we already manage the WDT and the profiler icons; * it makes the Exception independent from the location of the assets (and from the asset() function) * this is the second step to make the WebProfiler useable outside the full-stack framework see dbcd171
|
ok, I've reverted the removal of the images that might be useful in third-party bundles. |
fabpot
added a commit
that referenced
this pull request
Nov 14, 2012
This PR was merged into the master branch. Commits ------- 9f1cd84 moved most static assets directly into the templates Discussion ---------- moved most static assets directly into the templates This has been done for several reasons: * for consistency with the way we already manage the WDT and the profiler icons; * it makes the Exception independent from the location of the assets (and from the asset() function) * this is the second step to make the WebProfiler useable outside the full-stack framework see dbcd171 --------------------------------------------------------------------------- by stof at 2012-11-13T17:52:39Z the images blue_picto_more and blue_picto_less are also used in DoctrineBundle (and probably in JMSDebuggingBundle but I haven't checked). Could you submit a PR inlining the images too before removing them ? --------------------------------------------------------------------------- by fabpot at 2012-11-13T18:02:18Z Any image useful for other bundles should not be deleted. So, if DoctrineBundle is using the blue_pico_* images, I'm going to revert their deletion. --------------------------------------------------------------------------- by schmittjoh at 2012-11-13T18:07:02Z I'm using them in two bundles, JMSDebuggingBundle and JMSJobQueueBundle (same for the exception related templates). --------------------------------------------------------------------------- by dlsniper at 2012-11-13T22:22:29Z Wouldn't it be better to have the encoded icons in a separate CSS file as different classes/background images? --------------------------------------------------------------------------- by fabpot at 2012-11-14T11:28:24Z ok, I've reverted the removal of the images that might be useful in third-party bundles.
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was merged into the master branch. Commits ------- 9f1cd84 moved most static assets directly into the templates Discussion ---------- moved most static assets directly into the templates This has been done for several reasons: * for consistency with the way we already manage the WDT and the profiler icons; * it makes the Exception independent from the location of the assets (and from the asset() function) * this is the second step to make the WebProfiler useable outside the full-stack framework see dbcd171 --------------------------------------------------------------------------- by stof at 2012-11-13T17:52:39Z the images blue_picto_more and blue_picto_less are also used in DoctrineBundle (and probably in JMSDebuggingBundle but I haven't checked). Could you submit a PR inlining the images too before removing them ? --------------------------------------------------------------------------- by fabpot at 2012-11-13T18:02:18Z Any image useful for other bundles should not be deleted. So, if DoctrineBundle is using the blue_pico_* images, I'm going to revert their deletion. --------------------------------------------------------------------------- by schmittjoh at 2012-11-13T18:07:02Z I'm using them in two bundles, JMSDebuggingBundle and JMSJobQueueBundle (same for the exception related templates). --------------------------------------------------------------------------- by dlsniper at 2012-11-13T22:22:29Z Wouldn't it be better to have the encoded icons in a separate CSS file as different classes/background images? --------------------------------------------------------------------------- by fabpot at 2012-11-14T11:28:24Z ok, I've reverted the removal of the images that might be useful in third-party bundles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been done for several reasons:
profiler icons;
(and from the asset() function)
full-stack framework
see dbcd171