8000 [Security] Fix typos in OIDC methods by valtzu · Pull Request #59982 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Fix typos in OIDC methods #59982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

[Security] Fix typos in OIDC methods #59982

merged 1 commit into from
Mar 15, 2025

Conversation

valtzu
Copy link
Contributor
@valtzu valtzu commented Mar 15, 2025
Q A
Branch? 7.3
Bug fix? yes
New feature? no
License MIT

Related to recently merged OIDC discovery, the DI is configured to call enableDiscovery method but it does not exist – but there is enabledDiscovery.

Let's drop the extra d, and the same for enabledJweSupport too.

@valtzu valtzu requested a review from chalasr as a code owner March 15, 2025 14:17
@carsonbot carsonbot added this to the 7.3 milestone Mar 15, 2025
@fabpot
Copy link
Member
fabpot commented Mar 15, 2025

Good catch, thanks @valtzu.

@fabpot fabpot merged commit c3c37f2 into symfony:7.3 Mar 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@valtzu @fabpot @carsonbot
0