8000 chore: PHP CS Fixer fixes by keradus · Pull Request #59972 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

chore: PHP CS Fixer fixes #59972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

chore: PHP CS Fixer fixes #59972

merged 1 commit into from
Mar 17, 2025

Conversation

keradus
Copy link
Member
@keradus keradus commented Mar 13, 2025
Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues Fix CS
License MIT

with love by PHP Coding Standards Fixer

@keradus keradus requested review from chalasr and yceruto as code owners March 13, 2025 23:09
@carsonbot carsonbot added this to the 7.3 milestone Mar 13, 2025
@nicolas-grekas
Copy link
Member

Thank you @keradus.

@nicolas-grekas nicolas-grekas merged commit 0461860 into symfony:7.3 Mar 17, 2025
1 check was pending
@keradus keradus deleted the 7.3_cs_fixes branch March 17, 2025 21:34
@@ -17,6 +17,7 @@
use Symfony\Component\Clock\Clock;
use Symfony\Component\Clock\ClockInterface;
use Symfony\Component\Clock\MockClock;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that this (and the following changes) partially reverts #59939?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be some semi-conflicting rule when all needs to be applied to get final outcome.
Right now there is still lot of conflict between config and actually used style and I need to apply rule one by one. But it's only ~50 remaining issues to get clear state, then we will be able to apply whole config and stabilize the piece of code touched by multiple rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0