8000 [DoctrineBridge] add new `DatePointType` Doctrine type by garak · Pull Request #59900 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DoctrineBridge] add new DatePointType Doctrine type #59900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

[DoctrineBridge] add new DatePointType Doctrine type #59900

merged 1 commit into from
Mar 24, 2025

Conversation

garak
Copy link
Contributor
@garak garak commented Mar 3, 2025
Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #59889
License MIT

Add a new DoctrineType for the DatePoint class.
Please take a look at the issue mentioned above for more details.

@carsonbot carsonbot added this to the 7.3 milestone Mar 3, 2025
@OskarStark OskarStark changed the title add new DatePointType Doctrine type add new DatePointType Doctrine type Mar 3, 2025
@carsonbot carsonbot changed the title add new DatePointType Doctrine type [DoctrineBridge] add new DatePointType Doctrine type Mar 3, 2025
@garak
Copy link
Contributor Author
garak commented Mar 3, 2025

I can't understand the psalm failures, any help will be appreciated.
Moreover, I see that fabbot complains because I added some tests with return type, does it make sense?

@OskarStark
Copy link
Contributor

Moreover, I see that fabbot complains because I added some tests with return type, does it make sense?

Yes, we avoid the void return type in the Symfony codebase

@garak
Copy link
Contributor Author
garak commented Mar 3, 2025

I fixed the return types. The unit test failures seem unrelated.
I still need a hint about fixing the psalm inspection, thanks.