[Mailer] Fix mailer signer configuration issues #59855
Conversation
| @@ -2879,8 +2879,8 @@ private function registerMailerConfiguration(array $config, ContainerBuilder $co | |||
| throw new LogicException('SMIME signed messages support cannot be enabled as this version of the Mailer component does not support it.'); | |||
| } | |||
| $smimeSigner = $container->getDefinition('mailer.smime_signer'); | |||
| $smimeSigner->setArgument(0, $config['smime_signer']['key']); | |||
| $smimeSigner->setArgument(1, $config['smime_signer']['certificate']); | |||
| $smimeSigner->setArgument(0, $config['smime_signer']['certificate']); | |||
There was a problem hiding this comment.
the abstract args in mailer.smime_signer are describing key as the first argument. Are those descriptions wrong as well ?
There was a problem hiding this comment.
the abstract args in
mailer.smime_signerare describingkeyas the first argument. Are those descriptions wrong as well ?
Yes, I think so. Looks like the abstract_arg is not affecting in the scenario case described in the PR but probably is worth changing it in the Configuration and schema files.
There was a problem hiding this comment.
the description in abstract_arg is used if you forget to configure the argument to replace the abstract arg. As this line overrides the argument, you won't get an error message saying you forget to configure the key. But it is weird if descriptions don't match.
There was a problem hiding this comment.
Configuration and schema don't need to change. Those don't describe service definitions with ordered parameters. The order is not relevant there.
There was a problem hiding this comment.
Thanks for the clarification. I'll rollback Configuration and schema changes.
4f7e469 to
d8ba332
Compare
|
Thank you @eliasfernandez. |
Explanation here: #59854