8000 [AssetMapper] Removing `asnyc` from `<script>` tag of es-module-shims by ThomasLandauer · Pull Request #59808 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[AssetMapper] Removing asnyc from <script> tag of es-module-shims #59808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[AssetMapper] Removing asnyc from <script> tag of es-module-shims #59808

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor
Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues none
License MIT

https://validator.w3.org/nu/ is saying:

Error: Element script must not have attribute async unless attribute src is also specified or unless attribute type is specified with value module.

I don't know why async was added in the first place; and I don't have an old browser to test. Just wanted to make you aware that the current implementation looks invalid.

@carsonbot carsonbot added this to the 7.2 milestone Feb 18, 2025
@nicolas-grekas
Copy link
Member

We did this already in #59549, merged on branch 7.3.

@ThomasLandauer ThomasLandauer deleted the patch-2 branch February 19, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AssetMapper Bug Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @nicolas-grekas @carsonbot
0