[Notifier][Bluesky] Add support for tags facet #59784
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a line in the changelog, thanks |
4697321 to
a90ab12
Compare
| @@ -238,6 +238,39 @@ public function testParseFacetsUrlWithEmoji() | |||
| $this->assertEquals($expected, $output); | |||
| } | |||
|
|
|||
| public function testParseFacetsHashTags() | |||
| { | |||
| $input = 'Salut #test #123 #テスト http://bsky.app'; | |||
There was a problem hiding this comment.
Maybe you could update the URL http://bsky.app to use something like http://bsky.app#fragment to see if the regex doesn't catch the URL fragment as a hashtag. Thanks.
There was a problem hiding this comment.
Regarding URLs (and tags), this is already the default behavior when not using facets. Any benefits in doing it via facets?
fabpot
reviewed
Feb 17, 2025
| @@ -238,6 +238,39 @@ public function testParseFacetsUrlWithEmoji() | |||
| $this->assertEquals($expected, $output); | |||
| } | |||
|
|
|||
| public function testParseFacetsHashTags() | |||
| { | |||
| $input = 'Salut #test #123 #テスト http://bsky.app'; | |||
There was a problem hiding this comment.
Regarding URLs (and tags), this is already the default behavior when not using facets. Any benefits in doing it via facets?
|
friendly ping @romainneutron and can you also add an entry to the CHANGELOG? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tags facet on Bluesky notifier
The documentation is here https://docs.bsky.app/docs/advanced-guides/post-richtext