8000 Make data providers static by alexandre-daubois · Pull Request #59738 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make data providers static #59738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Make data providers static #59738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make data providers static
  • Loading branch information
@alexandre-daubois
alexandre-daubois committed Feb 10, 2025
commit 8bfa9a5a621a11a436732a8f5ffa9741d995bf2e
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ public function testWithEmbed(BlueskyOptions $blueskyOptions, string $expectedJs
$this->assertSame('103254962155278888', $result->getMessageId());
}

public function sendMessageWithEmbedDataProvider(): iterable
public static function sendMessageWithEmbedDataProvider(): iterable
{
yield 'With media' => [
'options' => (new BlueskyOptions())->attachMedia(new File(__DIR__.'/fixtures.gif'), 'A fixture'),
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/PropertyInfo/Tests/PropertyInfoCacheExtractorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function testIsInitializable()
*/
public function testNestedExtractorWithoutGetTypeImplementation(string $property, ?Type $expectedType)
{
$propertyInfoCacheExtractor = new PropertyInfoCacheExtractor(new class() implements PropertyInfoExtractorInterface {
$propertyInfoCacheExtractor = new PropertyInfoCacheExtractor(new class implements PropertyInfoExtractorInterface {
private PropertyTypeExtractorInterface $propertyTypeExtractor;

public function __construct()
Expand Down Expand Up @@ -136,7 +136,7 @@ public function getProperties(string $class, array $context = []): ?array
}
}

public function provideNestedExtractorWithoutGetTypeImplementationData()
public static function provideNestedExtractorWithoutGetTypeImplementationData()
{
yield ['bar', Type::string()];
yield ['baz', Type::int()];
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/PropertyInfo/Tests/PropertyInfoExtractorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class PropertyInfoExtractorTest extends AbstractPropertyInfoExtractorTest
*/
public function testNestedExtractorWithoutGetTypeImplementation(string $property, ?Type $expectedType)
{
$propertyInfoExtractor = new PropertyInfoExtractor([], [new class() implements PropertyTypeExtractorInterface {
$propertyInfoExtractor = new PropertyInfoExtractor([], [new class implements PropertyTypeExtractorInterface {
private PropertyTypeExtractorInterface $propertyTypeExtractor;

public function __construct()
Expand All @@ -51,7 +51,7 @@ public function getTypes(string $class, string $property, array $context = []):
}
}

public function provideNestedExtractorWithoutGetTypeImplementationData()
public static function provideNestedExtractorWithoutGetTypeImplementationData()
{
yield ['bar', Type::string()];
yield ['baz', Type::int()];
Expand Down
Loading
0