[DependencyInjection] Don't skip classes with private constructor when autodiscovering #59712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8da717 to
29582b0
Compare
|
Do we still have a compiler pass validating that services are either instantiable classes or have a factory configured, so that we get a clean error at build time for services that miss this configuration ? And if yes, do we need to update its error message to mention the possibility to use |
…n autodiscovering
29582b0 to
99830f6
Compare
|
We do have a compiler pass but it didn't tell about the attribute. PR updated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With value objects auto-discovery becoming more mainstream (see #59704), it's time to fix registering classes with private constructors.
Those are skipped today but with support for
#[Autoconfigure(constructor: 'createInstance')]as introduced in #49665, this doesn't make sense anymore.Best reviewed ignoring whitespace.