symfony · fabpot · Mar 26, 2025 · Jan 29, 2025
diff --git a/src/Symfony/Component/JsonStreamer/DataModel/FunctionDataAccessor.php b/src/Symfony/Component/JsonStreamer/DataModel/FunctionDataAccessor.php
@@ -33,6 +33,16 @@ public function __construct(
     ) {
     }
 
+    public function getObjectAccessor(): ?DataAccessorInterface
+    {
+        return $this->objectAccessor;
+    }
+
+    public function withObjectAccessor(?DataAccessorInterface $accessor): self
+    {
+        return new self($this->functionName, $this->arguments, $accessor);
+    }
+
     public function toPhpExpr(): Expr
     {
         $builder = new BuilderFactory();

diff --git a/src/Symfony/Component/JsonStreamer/DataModel/PropertyDataAccessor.php b/src/Symfony/Component/JsonStreamer/DataModel/PropertyDataAccessor.php
@@ -29,6 +29,16 @@ public function __construct(
     ) {
     }
 
+    public function getObjectAccessor(): DataAccessorInterface
+    {
+        return $this->objectAccessor;
+    }
+
+    public function withObjectAccessor(DataAccessorInterface $accessor): self
+    {
+        return new self($accessor, $this->propertyName);
+    }
+
     public function toPhpExpr(): Expr
     {
         return (new BuilderFactory())->propertyFetch($this->objectAccessor->toPhpExpr(), $this->propertyName);

diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Read/ObjectNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Read/ObjectNode.php
@@ -30,11 +30,11 @@ final class ObjectNode implements DataModelNodeInterface
     public function __construct(
         private ObjectType $type,
         private array $properties,
-        private bool $ghost = false,
+        private bool $mock = false,
     ) {
     }
 
-    public static function createGhost(ObjectType|UnionType $type): self
+    public static function createMock(ObjectType|UnionType $type): self
     {
         return new self($type, [], true);
     }
@@ -57,8 +57,8 @@ public function getProperties(): array
         return $this->properties;
     }
 
-    public function isGhost(): bool
+    public function isMock(): bool
     {
-        return $this->ghost;
+        return $this->mock;
     }
 }
diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/BackedEnumNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/BackedEnumNode.php
@@ -31,6 +31,16 @@ public function __construct(
     ) {
     }
 
+    public function withAccessor(DataAccessorInterface $accessor): self
+    {
+        return new self($accessor, $this->type);
+    }
+
+    public function getIdentifier(): string
+    {
+        return (string) $this->getType();
+    }
+
     public function getAccessor(): DataAccessorInterface
     {
         return $this->accessor;

diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/CollectionNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/CollectionNode.php
@@ -30,6 +30,16 @@ public function __construct(
     ) {
     }
 
+    public function withAccessor(DataAccessorInterface $accessor): self
+    {
+        return new self($accessor, $this->type, $this->item);
+    }
+
+    public function getIdentifier(): string
+    {
+        return (string) $this->getType();
+    }
+
     public function getAccessor(): DataAccessorInterface
     {
         return $this->accessor;

diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/CompositeNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/CompositeNode.php
@@ -60,6 +60,16 @@ public function __construct(
         $this->nodes = $nodes;
     }
 
+    public function withAccessor(DataAccessorInterface $accessor): self
+    {
+        return new self($accessor, array_map(static fn (DataModelNodeInterface $n): DataModelNodeInterface => $n->withAccessor($accessor), $this->nodes));
+    }
+
+    public function getIdentifier(): string
+    {
+        return (string) $this->getType();
+    }
+
     public function getAccessor(): DataAccessorInterface
     {
         return $this->accessor;

diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/DataModelNodeInterface.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/DataModelNodeInterface.php
@@ -23,7 +23,11 @@
  */
 interface DataModelNodeInterface
 {
+    public function getIdentifier(): string;
+
     public function getType(): Type;
 
     public function getAccessor(): DataAccessorInterface;
+
+    public function withAccessor(DataAccessorInterface $accessor): self;
 }
diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/ExceptionNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/ExceptionNode.php
diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/ObjectNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/ObjectNode.php
@@ -12,6 +12,8 @@
 namespace Symfony\Component\JsonStreamer\DataModel\Write;
 
 use Symfony\Component\JsonStreamer\DataModel\DataAccessorInterface;
+use Symfony\Component\JsonStreamer\DataModel\FunctionDataAccessor;
+use Symfony\Component\JsonStreamer\DataModel\PropertyDataAccessor;
 use Symfony\Component\TypeInfo\Type\ObjectType;
 
 /**
@@ -30,9 +32,36 @@ public function __construct(
         private DataAccessorInterface $accessor,
         private ObjectType $type,
         private array $properties,
+        private bool $mock = false,
     ) {
     }
 
+    public static function createMock(DataAccessorInterface $accessor, ObjectType $type): self
+    {
+        return new self($accessor, $type, [], true);
+    }
+
+    public function withAccessor(DataAccessorInterface $accessor): self
+    {
+        $properties = [];
+        foreach ($this->properties as $key => $property) {
+            $propertyAccessor = $property->getAccessor();
+
+            if ($propertyAccessor instanceof PropertyDataAccessor || $propertyAccessor instanceof FunctionDataAccessor && $propertyAccessor->getObjectAccessor()) {
+                $propertyAccessor = $propertyAccessor->withObjectAccessor($accessor);
+            }
+
+            $properties[$key] = $property->withAccessor($propertyAccessor);
+        }
+
+        return new self($accessor, $this->type, $properties, $this->mock);
+    }
+
+    public function getIdentifier(): string
+    {
+        return (string) $this->getType();
+    }
+
     public function getAccessor(): DataAccessorInterface
     {
         return $this->accessor;
@@ -50,4 +79,9 @@ public function getProperties(): array
     {
         return $this->properties;
     }
+
+    public function isMock(): bool
+    {
+        return $this->mock;
+    }
 }
diff --git a/src/Symfony/Component/JsonStreamer/DataModel/Write/ScalarNode.php b/src/Symfony/Component/JsonStreamer/DataModel/Write/ScalarNode.php
@@ -31,6 +31,16 @@ public function __construct(
     ) {
     }
 
+    public function withAccessor(DataAccessorInterface $accessor): self
+    {
+        return new self($accessor, $this->type);
+    }
+
+    public function getIdentifier(): string
+    {
+        return (string) $this->getType();
+    }
+
     public function getAccessor(): DataAccessorInterface
     {
         return $this->accessor;

diff --git a/...nStreamer/Exception/MaxDepthException.php → .../Exception/NotEncodableValueException.php b/...nStreamer/Exception/MaxDepthException.php → .../Exception/NotEncodableValueException.php
@@ -16,10 +16,6 @@
  *
  * @experimental
  */
-final class MaxDepthException extends RuntimeException
+class NotEncodableValueException extends UnexpectedValueException
 {
-    public function __construct()
-    {
-        parent::__construct('Max depth of 512 has been reached.');
-    }
 }
diff --git a/src/Symfony/Component/JsonStreamer/Read/PhpAstBuilder.php b/src/Symfony/Component/JsonStreamer/Read/PhpAstBuilder.php
@@ -421,7 +421,7 @@ private function buildCollectionNodeStatements(CollectionNode $node, bool $decod
      */
     private function buildObjectNodeStatements(ObjectNode $node, bool $decodeFromStream, array &$context): array
     {
-        if ($node->isGhost()) {
+        if ($node->isMock()) {
             return [];
         }
 

diff --git a/src/Symfony/Component/JsonStreamer/Read/StreamReaderGenerator.php b/src/Symfony/Component/JsonStreamer/Read/StreamReaderGenerator.php
@@ -123,7 +123,7 @@ public function createDataModel(Type $type, array $options = [], array $context
             $className = $type->getClassName();
 
             if ($context['generated_classes'][$typeString] ??= false) {
-                return ObjectNode::createGhost($type);
+                return ObjectNode::createMock($type);
             }
 
             $propertiesNodes = [];

diff --git a/src/Symfony/Component/JsonStreamer/Tests/DataModel/Write/CompositeNodeTest.php b/src/Symfony/Component/JsonStreamer/Tests/DataModel/Write/CompositeNodeTest.php
@@ -54,4 +54,17 @@ public function testSortNodesOnCreation()
 
         $this->assertSame([$collection, $object, $scalar], $composite->getNodes());
     }
+
+    public function testWithAccessor()
+    {
+        $composite = new CompositeNode(new VariableDataAccessor('data'), [
+            new ScalarNode(new VariableDataAccessor('foo'), Type::int()),
+            new ScalarNode(new VariableDataAccessor('bar'), Type::int()),
+        ]);
+        $composite = $composite->withAccessor($newAccessor = new VariableDataAccessor('baz'));
+
+        foreach ($composite->getNodes() as $node) {
+            $this->assertSame($newAccessor, $node->getAccessor());
+        }
+    }
 }
diff --git a/src/Symfony/Component/JsonStreamer/Tests/DataModel/Write/ObjectNodeTest.php b/src/Symfony/Component/JsonStreamer/Tests/DataModel/Write/ObjectNodeTest.php
@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\JsonStreamer\Tests\DataModel\Write;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\JsonStreamer\DataModel\FunctionDataAccessor;
+use Symfony\Component\JsonStreamer\DataModel\PropertyDataAccessor;
+use Symfony\Component\JsonStreamer\DataModel\VariableDataAccessor;
+use Symfony\Component\JsonStreamer\DataModel\Write\ObjectNode;
+use Symfony\Component\JsonStreamer\DataModel\Write\ScalarNode;
+use Symfony\Component\TypeInfo\Type;
+
+class ObjectNodeTest extends TestCase
+{
+    public function testWithAccessor()
+    {
+        $object = new ObjectNode(new VariableDataAccessor('foo'), Type::object(self::class), [
+            new ScalarNode(new PropertyDataAccessor(new VariableDataAccessor('foo'), 'property'), Type::int()),
+            new ScalarNode(new FunctionDataAccessor('function', [], new VariableDataAccessor('foo')), Type::int()),
+            new ScalarNode(new FunctionDataAccessor('function', []), Type::int()),
+            new ScalarNode(new VariableDataAccessor('bar'), Type::int()),
+        ]);
+        $object = $object->withAccessor($newAccessor = new VariableDataAccessor('baz'));
+
+        $this->assertSame($newAccessor, $object->getAccessor());
+        $this->assertSame($newAccessor, $object->getProperties()[0]->getAccessor()->getObjectAccessor());
+        $this->assertSame($newAccessor, $object->getProperties()[1]->getAccessor()->getObjectAccessor());
+        $this->assertNull($object->getProperties()[2]->getAccessor()->getObjectAccessor());
+        $this->assertNotSame($newAccessor, $object->getProperties()[3]->getAccessor());
+    }
+}
diff --git a/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/backed_enum.php b/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/backed_enum.php
@@ -1,5 +1,9 @@
 <?php
 
 return static function (mixed $data, \Psr\Container\ContainerInterface $valueTransformers, array $options): \Traversable {
-    yield \json_encode($data->value);
+    try {
+        yield \json_encode($data->value, \JSON_THROW_ON_ERROR, 512);
+    } catch (\JsonException $e) {
+        throw new \Symfony\Component\JsonStreamer\Exception\NotEncodableValueException($e->getMessage(), 0, $e);
+    }
 };
diff --git a/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/bool.php b/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/bool.php
@@ -1,5 +1,9 @@
 <?php
 
 return static function (mixed $data, \Psr\Container\ContainerInterface $valueTransformers, array $options): \Traversable {
-    yield $data ? 'true' : 'false';
+    try {
+        yield $data ? 'true' : 'false';
+    } catch (\JsonException $e) {
+        throw new \Symfony\Component\JsonStreamer\Exception\NotEncodableValueException($e->getMessage(), 0, $e);
+    }
 };
diff --git a/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/bool_list.php b/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/bool_list.php
@@ -1,5 +1,9 @@
 <?php
 
 return static function (mixed $data, \Psr\Container\ContainerInterface $valueTransformers, array $options): \Traversable {
-    yield \json_encode($data);
+    try {
+        yield \json_encode($data, \JSON_THROW_ON_ERROR, 512);
+    } catch (\JsonException $e) {
+        throw new \Symfony\Component\JsonStreamer\Exception\NotEncodableValueException($e->getMessage(), 0, $e);
+    }
 };
diff --git a/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/dict.php b/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/dict.php
@@ -1,5 +1,9 @@
 <?php
 
 return static function (mixed $data, \Psr\Container\ContainerInterface $valueTransformers, array $options): \Traversable {
-    yield \json_encode($data);
+    try {
+        yield \json_encode($data, \JSON_THROW_ON_ERROR, 512);
+    } catch (\JsonException $e) {
+        throw new \Symfony\Component\JsonStreamer\Exception\NotEncodableValueException($e->getMessage(), 0, $e);
+    }
 };
diff --git a/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/iterable.php b/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/iterable.php
@@ -1,5 +1,9 @@
 <?php
 
 return static function (mixed $data, \Psr\Container\ContainerInterface $valueTransformers, array $options): \Traversable {
-    yield \json_encode($data);
+    try {
+        yield \json_encode($data, \JSON_THROW_ON_ERROR, 512);
+    } catch (\JsonException $e) {
+        throw new \Symfony\Component\JsonStreamer\Exception\NotEncodableValueException($e->getMessage(), 0, $e);
+    }
 };
diff --git a/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/list.php b/src/Symfony/Component/JsonStreamer/Tests/Fixtures/stream_writer/list.php
@@ -1,5 +1,9 @@
 <?php
 
 return static function (mixed $data, \Psr\Container\ContainerInterface $valueTransformers, array $options): \Traversable {
-    yield \json_encode($data);
+    try {
+        yield \json_encode($data, \JSON_THROW_ON_ERROR, 512);
+    } catch (\JsonException $e) {
+        throw new \Symfony\Component\JsonStreamer\Exception\NotEncodableValueException($e->getMessage(), 0, $e);
+    }
 };