[FrameworkBundle] Remove unused node definition #59628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
GromNaN
reviewed
Jan 27, 2025
| @@ -1056,10 +1056,6 @@ private function addValidationSection(ArrayNodeDefinition $rootNode, callable $e | |||
| ->arrayNode('not_compromised_password') | |||
| ->canBeDisabled() | |||
| ->children() | |||
| ->booleanNode('enabled') | |||
| ->defaultTrue() | |||
| ->info('When disabled, compromised passwords will be accepted as valid.') | |||
There was a problem hiding this comment.
Ne feature proposal: canBeDisabled could accept a parameter for the info.
There was a problem hiding this comment.
I think you're right and I should work on that instead, seems a better option to not loose info, even if it seems self-explanatory in this case.
nicolas-grekas
added a commit
that referenced
this pull request
Jan 28, 2025
…finition::canBeEnabled()` and `ArrayNodeDefinition::canBeDisabled()` (alexandre-daubois) This PR was merged into the 7.3 branch. Discussion ---------- [FrameworkBundle] Add support for info on `ArrayNodeDefinition::canBeEnabled()` and `ArrayNodeDefinition::canBeDisabled()` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT After #59628 (comment) (cc `@GromNaN`), supersedes #59628 is merged. Commits ------- 857b778 [FrameworkBundle] Add support for info on `ArrayNodeDefinition::canBeEnabled()` and `ArrayNodeDefinition::canBeDisabled()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canBeDisabled()is called, thus adding theenablednode adds nothing but unused code in this huge class. May be superseded by #59630.