8000 [Notifier][Smsbox] Add webhook support by alanzarli · Pull Request #59570 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier][Smsbox] Add webhook support #59570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[Notifier][Smsbox] Add webhook support #59570

merged 1 commit into from
Feb 28, 2025

Conversation

alanzarli
Copy link
@alanzarli alanzarli commented Jan 21, 2025 •
edited
Loading
Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc #20590

Add support for Webhook to Smsbox Notifier
Event statuses come from Smsbox documentation.

@carsonbot carsonbot added this to the 7.3 milestone Jan 21, 2025
@alanzarli alanzarli force-pushed the smsbox-notifier branch 3 times, most recently from c0ecd8b to 95bb117 Compare January 31, 2025 15:58
fabpot
fabpot requested changes Feb 10, 2025
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the deps for framework bundle to fix the broken tests.

@alanzarli
Copy link
Author

done 👍

@OskarStark OskarStark requested a review from fabpot February 11, 2025 10:22
@OskarStark
Copy link
Contributor
OskarStark commented Feb 28, 2025 •
edited
Loading

Thanks Alan for working on this feature, this is much appreciated and congrats on your first contribution to the Symfony framework 🎉 👏

@OskarStark OskarStark merged commit 35202a2 into symfony:7.3 Feb 28, 2025
9 of 11 checks passed
@OskarStark OskarStark changed the title [Notifier][Webhook] Add Smsbox support [Notifier][Smsbox] Add webhook support Feb 28, 2025
@smsbox-net smsbox-net deleted the smsbox-notifier branch February 28, 2025 13:29
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
@xabbuh xabbuh mentioned this pull request May 16, 2025
Merged
OskarStark added a commit that referenced this pull request May 16, 2025
@OskarStark
minor #60434 [Notifier] simplify Webhook constraint (xabbuh)
5718323 
This PR was merged into the 7.3 branch.

Discussion
----------

[Notifier] simplify Webhook constraint

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

introduced in #59570

Commits
-------

193b69c simplify Webhook constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@OskarStark OskarStark OskarStark approved these changes

@chalasr chalasr Awaiting requested review from chalasr

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review Webhook
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@alanzarli @OskarStark @fabpot @welcoMattic @carsonbot
0