8000 [Messenger] [AMQP] Add TransportMessageIdStamp logic for AMQP by AurelienPillevesse · Pull Request #59526 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] [AMQP] Add TransportMessageIdStamp logic for AMQP #59526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

[Messenger] [AMQP] Add TransportMessageIdStamp logic for AMQP #59526

merged 1 commit into from
Feb 17, 2025

Conversation

AurelienPillevesse
Copy link
Contributor
@AurelienPillevesse AurelienPillevesse commented Jan 16, 2025 •
edited
Loading
Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Use TransportMessageIdStamp for AMQP bridge like Doctrine bridge for example.

Implement it in AmqpSender as DoctrineSender (https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineSender.php#L51)
Implement it in AmqpReceiver as DoctrineReceiver (https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/DoctrineReceiver.php#L148)

With this update, logger for AMQP will have more context with message_id data (https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php#L55)

@carsonbot carsonbot added this to the 7.3 milestone Jan 16, 2025
@AurelienPillevesse
Copy link
Contributor Author

Errors are not related to this PR

@AurelienPillevesse
Copy link
Contributor Author

I choose 7.3 but I don't know if it's a new feature or not (because already present in other transports).
If you want to merge it to 7.2, it's OK for me.
@nicolas-grekas

@fabpot fabpot force-pushed the add-amqp-transport-message-id-stamp-logic branch from e326e92 to 4bcb380 Compare February 17, 2025 09:08
@fabpot
Copy link
Member
fabpot commented Feb 17, 2025

Thank you @AurelienPillevesse.

@fabpot fabpot merged commit f48e068 into symfony:7.3 Feb 17, 2025
5 checks passed
@fabpot fabpot mentioned this pull request Feb 17, 2025
Open
@AurelienPillevesse AurelienPillevesse deleted the add-amqp-transport-message-id-stamp-logic branch February 17, 2025 09:11
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@AurelienPillevesse @fabpot @nicolas-grekas @carsonbot
0