[AssetMapper] Add --dry-run option on importmap:require command#59464
Merged
fabpot merged 1 commit intosymfony:7.3from Mar 10, 2025
Merged
Conversation
b4ec116 to
ed6a4d2
Compare
chalasr
requested changes
Jan 21, 2025
Member
There was a problem hiding this comment.
Please add an entry in the UPGRADE-7.3 file also
src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
Outdated
Show resolved
Hide resolved
ed6a4d2 to
97354d5
Compare
stof
reviewed
Jan 27, 2025
src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
Outdated
Show resolved
Hide resolved
467ac15 to
4ca59ff
Compare
Contributor
Author
|
Status: Needs Review |
4062322 to
e834020
Compare
Contributor
|
I cannot see the images in the PR header |
Contributor
Author
|
@OskarStark thanks, it is ok now, it was a copy / paste from a private repository. I take note about that and the images ^^' |
Member
|
e834020 to
4ce815f
Compare
4ce815f to
8537fff
Compare
Member
|
Anything here to be added @chalasr ? |
fabpot
requested changes
Mar 3, 2025
src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
Outdated
Show resolved
Hide resolved
8537fff to
337c465
Compare
fabpot
approved these changes
Mar 10, 2025
Member
|
Thank you @chadyred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working with @smnandre on several ideas to improve AssetMapper DX, focusing here on the
importmap:requirecommand.Currently, there is no way to know in advance which dependent packages will be downloaded too, and the final output display lacks clarity.
This PR aims to solve both issues by adding a new
--dry-runflag and reworking the command output (with-vverbosity)Console output
New
--dry-runoptionThis flag allows developers to simulate the installation process, without any alteration:
importmap.phpfile;assetsandpublicdirectories.The
--dry-runflag allows developers to:bootrapinstead ofbootstrap, orjquery);bootstrapwill also install@popperjs/core);The console will display a line at start and end of execution to signal the dry-run mode.
Console output
php bin/console importmap:require bootstrap --dry-run [DRY-RUN] No changes will apply to the importmap configuration. [OK] 3 new items (bootstrap, @popperjs/core, bootstrap/dist/css/bootstrap.min.css) added to the importmap.php! [DRY-RUN] No changes applied to the importmap configuration.New
-vverbose outputThis PR also reworks the output for the
-v(verbose) flag to provide more clarity when running the command with additional verbosity.All feedback welcome!
Footnotes
AssetMapper recursively extracts the dependencies of JavaScript modules. Even with the
--dry-runoption, theimportmap:requirecommand requires a workingHttpClientto download metadata and JavaScript files from various registries/repositories (mainly JSDelivr for now). ↩