Use spl_object_id() instead of spl_object_hash()
#59355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a benchmark which proves that using |
|
I used the benchmark from |
OskarStark
approved these changes
Jan 3, 2025
spl_object_id() instead of spl_object_hash()
spl_object_id() instead of spl_object_hash()spl_object_id() instead of spl_object_hash()
antonkomarev
reviewed
Jan 3, 2025
src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
Outdated
Show resolved
Hide resolved
|
|
|
@jderusse as it stated in official documentation it's working exactly same as hash |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Jan 4, 2025
…uiluz) This PR was merged into the 4.x branch. Discussion ---------- Minor performance improvement in Twig extension `spl_object_id()` is slightly faster than `spl_object_hash()` (see symfony/symfony#59355) and `xxhash` algorithms are much faster than `md5` Commits ------- f595045 Minor performance improvement in Twig extension
src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Lock/Store/DoctrineDbalPostgreSqlStore.php
Outdated
Show resolved
Hide resolved
|
Thank you @rosier. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Lock] Use a WeakMap as store registry | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT As suggested here #59355 (comment) Commits ------- ba1c9e3 Use a WeakMap as store registry
symfony-splitter
pushed a commit
to symfony/lock
that referenced
this pull request
Jan 6, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Lock] Use a WeakMap as store registry | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT As suggested here symfony/symfony#59355 (comment) Commits ------- ba1c9e3ae08 Use a WeakMap as store registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small performance tweak.