[Messenger] Add BeanstalkdPriorityStamp to Beanstalkd bridge
#59273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c758b07 to
9926d59
Compare
fabpot
reviewed
Jan 4, 2025
| final readonly class BeanstalkdPriorityStamp implements StampInterface | ||
| { | ||
| public function __construct( | ||
| public int $priority, |
There was a problem hiding this comment.
Maybe?
Suggested change
| public int $priority, | |
| public readonly int $priority, |
There was a problem hiding this comment.
@fabpot No need, the class itself is readonly.
fabpot
approved these changes
Jan 5, 2025
|
Thank you @HypeMC. |
fabpot
added a commit
that referenced
this pull request
Feb 7, 2025
…bridge (HypeMC) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [Messenger] Add `bury_on_reject` option to Beanstalkd bridge | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - ~~Contains #59273.~~ ~~This PR adds two improvements to the Beanstalkd bridge:~~ 1. Beanstalkd has the concept of "buried" jobs, which is a way of denoting that something has gone wrong while the consumer was processing the job. This PR adds a `bury_on_reject` option to bury rejected messages instead of deleting them, which is the current behavior. Since Symfony messenger's retry mechanism sends a new message for each retry and rejects the old one, it would create multiple buried jobs for each failed one. To avoid this issue a `SentForRetryStamp` was added to identify whether a failed message was sent for retry or not. As long as the retry mechanism keeps sending a new message, the old one will be deleted. Once it finishes, the final rejected message will be buried. ```yaml framework: messenger: transports: some_name: dsn: '%env(MESSENGER_TRANSPORT_DSN)%' options: bury_on_reject: true ``` 2. Extracted to #59273 Commits ------- 9f4b8a4 [Messenger] Add `bury_on_reject` option to Beanstalkd bridge
Spomky
added a commit
to Spomky/symfony-docs
that referenced
this pull request
Feb 26, 2025
Adds explanation about the new `BeanstalkdPriorityStamp` introduced by symfony/symfony#59273 Fixes symfony#20513
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 27, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Messenger][Beanstalkd] Add Priority support Adds explanation about the new `BeanstalkdPriorityStamp` introduced by symfony/symfony#59273. Fixes #20513. Ping `@HypeMC` for the review. Regards. Commits ------- 63fc4e0 [Messenger] Priority support for Beanstalkd bridge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #49652 as the original PR was trying to do two separate things in one.
Beanstalkd has the ability to configure the priority at which messages are reserved. This can now be set using the
BeanstalkdPriorityStamp: