8000 [FrameworkBundle] Rename TranslationUpdateCommand to TranslationExtract command to match the command name by welcoMattic · Pull Request #59105 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Rename TranslationUpdateCommand to TranslationExtract command to match the command name #59105

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

welcoMattic
Copy link
Member
Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? yes
Issues Fix #...
License MIT

In #43758, translation:update command has been renamed to translation:extract command. But the file has never been renamed. This PR deprecate the TranslationUpdateCommand class in favor to TranslationExtractCommand. So, in 8.0 we could remove TranslationUpdateCommand file completely.

@carsonbot carsonbot added this to the 7.3 milestone Dec 6, 2024
@welcoMattic welcoMattic force-pushed the translation-extract-command-rename branch 2 times, most recently from 42a1f4c to c218379 Compare December 6, 2024 08:44
@welcoMattic welcoMattic requested review from stof and Nyholm December 6, 2024 08:44
@welcoMattic welcoMattic force-pushed the translation-extract-command-rename branch from c218379 to 45a3131 Compare December 6, 2024 09:41
@carsonbot carsonbot changed the title Rename TranslationUpdateCommand to TranslationExtract command to match the command name [FrameworkBundle] Rename TranslationUpdateCommand to TranslationExtract command to match the command name Dec 6, 2024
@fabpot fabpot force-pushed the translation-extract-command-rename branch from 45a3131 to a61bd89 Compare December 7, 2024 07:58
@fabpot
A2FB Copy link
Member
fabpot commented Dec 7, 2024

Thank you @welcoMattic.

@fabpot fabpot merged commit b6d6adf into symfony:7.3 Dec 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0