Allow Custom Roles to implement the RoleInterface #5909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Custom roles to implement the RoleInterface rather than concreate class. Otherwise, in the constructor, if a custom role (that implements the interface only) is provided, the if statement is never entered. And then the comparison in equals method fails too. Spent an honour debugging why my class level roles based permissions weren't working.
|
👍 |
|
@schmittjoh could you finally take some time to explain why you rejecte dthis change more than 1 year ago as being a security issue (but without answering when people asked which issue) ? This would avoid receving duplicate every month. |
|
Closing as this is a duplicate. |
m14t
added a commit
to m14t/symfony-docs
that referenced
this pull request
Apr 23, 2013
The documentation seems to assume the implementation present in commit symfony/symfony#1673, which reverted soon after due to a potential, but undisclosed security hole (citation @schmittjoh in symfony/symfony@af70ac8). This incorrect documentation has likely been the source of many of the following issues: * symfony/symfony#1538 - [ACL RoleSecurityIdentity] check if instance of Role * symfony/symfony#1748 - Replace Role to RoleInterface for RoleSecurityIdentity * symfony/symfony#4309 - Issue related to custom group (role) and ACL/ACE * symfony/symfony#5026 - potential bug in Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity * symfony/symfony#5076 - [Acl] altered the behaviour of RoleSecurityIdentity * symfony/symfony#5171 - Fix/role security identity * symfony/symfony#5303 - [Security] Check for RoleInterface instead of Role object in RoleSecurityIdentity * symfony/symfony#5909 - Allow Custom Roles to implement the RoleInterface * symfony/symfony#6012 - Securityidentity fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Custom roles to implement the RoleInterface rather than concreate class.
Otherwise, in the constructor, if a custom role (that implements the interface only)
is provided, the if statement is never entered.
And then the comparison in equals method fails too.
Spent an honour debugging why my class level roles based permissions
weren't working.