Added note not to install as a dev requirement #58930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this package leans towar 8000 ds dev use, some people may be tempted to install as a dev requirement, but this will not (currently) work, so let's make that clear.
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "5.4, 6.4, and 7.1". Cheers! Carsonbot |
|
Sorry but it makes no sense to add this note. This is way too specific. |
|
@nicolas-grekas can you help me understand the issue with this, as this note would have saved me about 45 miniutes of trying to work out why this wasn't working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this package leans towards dev use, some people may be tempted to
install as a dev requirement, but this will not (currently) work, so
let's make that clear.