8000 [String] Fix some spellings in `EnglishInflector` by alexandre-daubois · Pull Request #58799 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[String] Fix some spellings in EnglishInflector #58799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

[String] Fix some spellings in EnglishInflector #58799

merged 1 commit into from
Nov 11, 2024

Conversation

alexandre-daubois
Copy link
Member
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58797
License MIT

Fixing the issue highlighted a spelling error for "fax" as well (https://en.wiktionary.org/wiki/fax#English)

@carsonbot carsonbot added this to the 5.4 milestone Nov 7, 2024
@alexandre-daubois alexandre-daubois force-pushed the inflector-fix branch 2 times, most recently from e58e369 to b7e7b6c Compare November 8, 2024 09:03
fabpot
fabpot reviewed Nov 9, 2024
View reviewed changes
src/Symfony/Component/String/Inflector/EnglishInflector.php Outdated
// boxes (box)
['xo', 2, false, true, 'oxes'],

// indexes (index), matrixes (matrix)
['x', 1, true, false, ['cies', 'xes']],
['x', 1, true, false, ['ces', 'xes']],

// appendices (appendix)
['xi', 2, false, true, 'ices'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be moved before x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually merge both, I updated the PR

@fabpot
Copy link
Member
fabpot commented Nov 11, 2024

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 439a278 into symfony:5.4 Nov 11, 2024
11 of 12 checks passed
This was referenced Nov 13, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed String
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @fabpot @OskarStark @xabbuh @carsonbot
0