8000 [Notifier] [Brevo][SMS] Brevo sms notifier add options by ikerib · Pull Request #58786 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] [Brevo][SMS] Brevo sms notifier add options #58786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2025
Merged

[Notifier] [Brevo][SMS] Brevo sms notifier add options #58786

merged 1 commit into from
Jan 5, 2025

Conversation

ikerib
Copy link
Contributor
@ikerib ikerib commented Nov 6, 2024 •
edited
Loading
Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Added webhook, tag options to brevo notifier
License MIT

I have used brevo-notifier and I realized that it was missing some options like the url address of the webhook, tags... I have added them.

I hope that I did well the pull request and everything related...

@ikerib ikerib requested a review from OskarStark as a code owner November 6, 2024 12:49
@carsonbot carsonbot added this to the 7.2 milestone Nov 6, 2024
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch ">6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Notifier][Brevo][SMS] Brevo sms notifier add options [Notifier] [Brevo][SMS] Brevo sms notifier add options Nov 6, 2024
@ikerib ikerib changed the title [Notifier] [Brevo][SMS] Brevo sms notifier add options [Notifier][Brevo][SMS] Brevo sms notifier add options Nov 6, 2024
@ikerib ikerib changed the base branch from 7.2 to 6.4 November 6, 2024 13:00
@stof
Copy link
Member
stof commented Nov 6, 2024

Adding support for new options is a new feature, not a bugfix. So this should go in the next minor version, not in 6.4.

@ikerib
Copy link
Contributor Author
ikerib commented Nov 6, 2024

oh! sorry!

@ikerib ikerib changed the base branch from 6.4 to 7.2 November 6, 2024 13:27
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@carsonbot carsonbot changed the title [Notifier][Brevo][SMS] Brevo sms notifier add options [Notifier] [Brevo][SMS] Brevo sms notifier add options Jan 5, 2025
@fabpot fabpot force-pushed the brevo-sms-notifier branch from eb4db72 to 1791f01 Compare January 5, 2025 10:36
@fabpot
Copy link
Member
fabpot commented Jan 5, 2025

Thank you @ikerib.

@fabpot fabpot merged commit ae5843f into symfony:7.3 Jan 5, 2025
7 of 9 checks passed
@fabpot fabpot mentioned this pull request Jan 5, 2025
Closed
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@ikerib @carsonbot @stof @fabpot
0