Exception when using File move() across local partition & NFS share #5878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h network shares (ie: NFS)
fabpot
added a commit
to fabpot/symfony
that referenced
this pull request
Dec 6, 2012
…le() when possible (closes symfony#5878, closes symfony#6185)
|
Here is my take: #6211 |
|
closing in favor of #6211 |
fabpot
added a commit
to fabpot/symfony
that referenced
this pull request
Dec 7, 2012
…le() when possible (closes symfony#5878, closes symfony#6185)
fabpot
added a commit
that referenced
this pull request
Dec 7, 2012
This PR was merged into the 2.0 branch. Commits ------- 447ff91 [HttpFoundation] changed UploadedFile::move() to use move_uploaded_file() when possible (closes #5878, closes #6185) Discussion ---------- [HttpFoundation] changed UploadedFile::move() to use move_uploaded_file() when possible (closes #5878, closes #6185) An alternative for #5878 and it fixes #6185.
fabpot
added a commit
that referenced
this pull request
Dec 7, 2012
* 2.0: [HttpFoundation] changed UploadedFile::move() to use move_uploaded_file() when possible (closes #5878, closes #6185) [HttpFoundation] added a check for the host header value Conflicts: src/Symfony/Component/HttpFoundation/File/File.php src/Symfony/Component/HttpFoundation/Request.php src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
fabpot
added a commit
that referenced
this pull request
Dec 7, 2012
* 2.1: [HttpFoundation] changed UploadedFile::move() to use move_uploaded_file() when possible (closes #5878, closes #6185) [HttpFoundation] added a check for the host header value [DoctrineBridge] Improved performance of the EntityType when used with the "query_builder" option [DoctrineBridge] Improved exception message [DoctrineBridge] Fixed: Exception is thrown if the entity class is not known to Doctrine Removed useless branch alias for dev-master in composer.json Conflicts: composer.json src/Symfony/Bridge/Doctrine/composer.json src/Symfony/Bridge/Monolog/composer.json src/Symfony/Bridge/Propel1/composer.json src/Symfony/Bridge/Swiftmailer/composer.json src/Symfony/Bridge/Twig/composer.json src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Bundle/SecurityBundle/composer.json src/Symfony/Bundle/TwigBundle/composer.json src/Symfony/Bundle/WebProfilerBundle/composer.json src/Symfony/Component/BrowserKit/composer.json src/Symfony/Component/ClassLoader/composer.json src/Symfony/Component/Config/composer.json src/Symfony/Component/Console/composer.json src/Symfony/Component/CssSelector/composer.json src/Symfony/Component/DependencyInjection/composer.json src/Symfony/Component/DomCrawler/composer.json src/Symfony/Component/EventDispatcher/composer.json src/Symfony/Component/Filesystem/composer.json src/Symfony/Component/Finder/composer.json src/Symfony/Component/Form/composer.json src/Symfony/Component/HttpFoundation/composer.json src/Symfony/Component/HttpKernel/composer.json src/Symfony/Component/Locale/composer.json src/Symfony/Component/OptionsResolver/composer.json src/Symfony/Component/Process/composer.json src/Symfony/Component/Routing/composer.json src/Symfony/Component/Security/composer.json src/Symfony/Component/Serializer/composer.json src/Symfony/Component/Templating/composer.json src/Symfony/Component/Translation/composer.json src/Symfony/Component/Validator/composer.json src/Symfony/Component/Yaml/composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We've faced an issue using move() function to move a local file to a locally mounted network share. The root cause seems to be PHP's rename() function failing in this use case.
This patch is, by design, less atomic than your current function as it performs the move in 2 steps ( copy() then unlink() ) but allow usage of this function in all types of infrastructures.
Bests