8000 [WebProfilerBoundle] form data collector check passed and resolved options are defined by vltrof · Pull Request #58739 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBoundle] form data collector check passed and resolved options are defined #58739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

[WebProfilerBoundle] form data collector check passed and resolved options are defined #58739

merged 1 commit into from
Nov 4, 2024

Conversation

vltrof
Copy link
Contributor
@vltrof vltrof commented Nov 3, 2024 •
edited by nicolas-grekas
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58665
License MIT

Greetings!
When passed or resolved value casted to false (null/false) it sets wrong value what cause exceptions described in issue. Explicit check if value defined prevent this behavior
Maybe codestyle should be fixed because of ternary

@carsonbot carsonbot added this to the 6.4 milestone Nov 3, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 5.4 Nov 4, 2024
@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 5.4 November 4, 2024 11:02
@nicolas-grekas
Copy link
Member

Thank you @vltrof.

@nicolas-grekas nicolas-grekas merged commit 25c9cbe into symfony:5.4 Nov 4, 2024
11 of 12 checks passed
@vltrof vltrof deleted the fix_58665 branch November 4, 2024 11:59
This was referenced Nov 6, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@vltrof @carsonbot @nicolas-grekas
0