8000 [WebProfilerBundle] Re-add missing Profiler shortcuts on Profiler homepage by welcoMattic · Pull Request #58728 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Re-add missing Profiler shortcuts on Profiler homepage #58728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

[WebProfilerBundle] Re-add missing Profiler shortcuts on Profiler homepage #58728

merged 1 commit into from
Nov 4, 2024

Conversation

welcoMattic
Copy link
Member
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58693
License MIT

Before Profiler redesign, on "homepage" (/_profiler path), there was sidebar shortcuts ("Last 10", "Latest", and "Search").
Screenshot 2024-10-31 at 15-04-50 Symfony Profiler

Since this redesign, as mentioned in the related issue, shortcuts have disappeared
Screenshot 2024-10-31 at 15-05-22 Symfony Profiler

I've fixed it on this PR, it works exactly like before the redesign

Screenshot 2024-10-31 8000 at 15-05-46 Symfony Profiler

@carsonbot carsonbot added the Bug label Oct 31, 2024
@carsonbot carsonbot added this to the 7.2 milestone Oct 31, 2024
@welcoMattic welcoMattic changed the base branch from 7.2 to 6.4 October 31, 2024 14:12
@symfony symfony deleted a comment from carsonbot Oct 31, 2024
@welcoMattic welcoMattic removed this from the 7.2 milestone Oct 31, 2024
@OskarStark OskarStark added this to the 6.4 milestone Oct 31, 2024
@carsonbot carsonbot changed the title Re-add missing Profiler shortcuts on Profiler homepage [WebProfilerBundle] Re-add missing Profiler shortcuts on Profiler homepage Nov 1, 2024
@nicolas-grekas
Copy link
Member

Thank you @welcoMattic.

@nicolas-grekas nicolas-grekas merged commit a7aa4b1 into symfony:6.4 Nov 4, 2024
1 of 2 checks passed
@xabbuh
Copy link
Member
xabbuh commented Nov 4, 2024

I have merged the PR up into the 7.1. There the template already looked a bit different. Can you check if the branch still needs an update?

This was referenced Nov 6, 2024
Merged
Merged
Merged
@welcoMattic welcoMattic deleted the fix-profiler-latest-shorcut branch April 18, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Profiler] Latest button is no longer present
6 participants
@welcoMattic @nicolas-grekas @xabbuh @OskarStark @derrabus @carsonbot
0