8000 switch from AppVeyor to GitHub Actions to run tests on Windows by xabbuh · Pull Request #58721 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

switch from AppVeyor to GitHub Actions to run tests on Windows #58721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub&rdquo 10000 ;, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

switch from AppVeyor to GitHub Actions to run tests on Windows #58721

merged 1 commit into from
Nov 6, 2024

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Oct 30, 2024
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

In #58370 I tried hard but failed to get our test suite running with PHPUnit 11 on AppVeyor. @wouterj did a great job reviving an old branch and got it working on GitHub Actions in #58699. I picked his commit and rebased it on the 5.4 branch so that we are able to have a consistent CI config throughout all maintained branches.

@carsonbot carsonbot added this to the 5.4 milestone Oct 30, 2024
@chadyred
Copy link
Contributor

Oh, sounds good guys 🙏 I discovered AppVeyor by searching why tests go away sometimes for no reason ^^

stof
stof reviewed Oct 30, 2024
View reviewed changes
@wouterj wouterj mentioned this pull request Oct 30, 2024
Closed
@xabbuh xabbuh force-pushed the gha-windows branch 16 times, most recently from d12a878 to 4032018 Compare November 5, 2024 12:13
@xabbuh xabbuh mentioned this pull request Nov 5, 2024
Merged
@xabbuh xabbuh force-pushed the gha-windows branch 3 times, most recently from 0f29271 to f606338 Compare November 6, 2024 11:38
@xabbuh xabbuh requested a review from chalasr as a code owner November 6, 2024 11:38
@OskarStark
Copy link
Contributor

You did an amazing job, thank you very much. 🖖

nicolas-grekas
nicolas-grekas reviewed Nov 6, 2024
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to pptimize the display in the GH UI :)

@nicolas-grekas
Copy link
Member

Thank you @wouterj and @xabbuh \o/

@nicolas-grekas nicolas-grekas merged commit 2c7c4ba into symfony:5.4 Nov 6, 2024
10 of 12 checks passed
@wouterj
Copy link
Member
wouterj commented Nov 6, 2024 •
edited
Loading

Wohoo! 🚀 Thanks for all the debugging work @xabbuh!

Next step I will experiment with: ForEach -Parallel to do the similar parallelization as we do in the Linux builds. Managed to get powershell running in Docker so I can properly test this locally.

@xabbuh xabbuh deleted the gha-windows branch November 6, 2024 14:49
@xabbuh xabbuh mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@wouterj wouterj wouterj left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @chadyred @OskarStark @nicolas-grekas @wouterj @stof @carsonbot
0