8000 [Cache] add tests covering getMultiple() with a wrapped tag aware adapter by xabbuh · Pull Request #58640 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] add tests covering getMultiple() with a wrapped tag aware adapter #58640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign u 8000 p for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Cache] add tests covering getMultiple() with a wrapped tag aware adapter #58640

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Oct 23, 2024
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

This is the same test that is included in the bugfix PR #58639 proving that the getMultiple() method worked as expected in 5.4 before the refactoring that happened in #42997.

@carsonbot carsonbot added this to the 5.4 milestone Oct 23, 2024
@carsonbot carsonbot changed the title [Cache] add tests covering getMultiple() with a wrapped tag aware adapter [Cache] add tests covering getMultiple() with a wrapped tag aware adapter Oct 23, 2024
@nicolas-grekas
Copy link
Member

We might miss a test that covers this line:

symfony/src/Symfony/Component/Cache/Psr16Cache.php

Line 192 in f42d2ce

$values[$key] = ["\x9D".pack('VN', (int) (0.1 + $metadata[CacheItem::METADATA_EXPIRY] - self::METADATA_EXPIRY_OFFSET), $metadata[CacheItem::METADATA_CTIME])."\x5F" => $values[$key]];

Having one might tell us when we need the packing call in #42997 (but it should likely be conditional, like it is on 5.4)

@xabbuh
Copy link
Member Author
xabbuh commented Oct 23, 2024

I am closing here as the failing tests in the linked PR show that it’s not that simple as I thought.

@xabbuh xabbuh closed this Oct 23, 2024
@xabbuh xabbuh deleted the issue-58632-5.4-test branch October 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cache Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot
0