[Validator] [DateTime] Add format to error messages
#58559
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hi, thanks for this new feature. New features need to target the latest branch, which is |
@OskarStark Thank you for your quick review. Changed the target branch to latest ( |
format to error messages
|
Duplicate of #58602, which was rejected. |
|
Aaah sorry I was too fast, that's different. |
|
Please add a line to the changelog of the component. |
9e2f5ad to
d5beef3
Compare
|
@nicolas-grekas Thank you for your comment. Added changes to changelog |
|
Bump, anything else I need to add/change to move this forward ? |
996e398 to
a695074
Compare
a695074 to
20e83b9
Compare
|
Thank you @saulius334. |
This PR was merged into the 7.3 branch. Discussion ---------- [MonologBridge] revert test changes | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT I fail to see why these changes have been done in #58559. Commits ------- 71d8ec0 revert test changes
Problem
Currently there is no way to dynamically add the
formatvalue into error messages when using theDateTimeconstraint. It has to be hardcoded on everyDateTimeconstraint.For example:
Goal
The goal is to add the possibility to use a parameter instead of hardcoding the selected format.
For example:
If using the symfony translator we would even not need to set the message when creating the constraint.
For example:
Solution
When building the violations set a new parameter called
formatwhich represents the givenformatwhen theDateTimeconstraint is created.