[Routing][Uid] [6.4] Mention RFC 9562 #58329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Sep 20, 2024
| @@ -23,7 +23,7 @@ enum Requirement | |||
| public const POSITIVE_INT = '[1-9][0-9]*'; | |||
| public const UID_BASE32 = '[0-9A-HJKMNP-TV-Z]{26}'; | |||
| public const UID_BASE58 = '[1-9A-HJ-NP-Za-km-z]{22}'; | |||
| public const UID_RFC4122 = '[0-9a-f]{8}(?:-[0-9a-f]{4}){3}-[0-9a-f]{12}'; | |||
| public const UID_RFC4122 = '[0-9a-f]{8}(?:-[0-9a-f]{4}){3}-[0-9a-f]{12}'; // RFC 9562 obsoleted RFC 4122 but the format is the same | |||
There was a problem hiding this comment.
@alexandre-daubois I guess we can add a new constant here as well?!
There was a problem hiding this comment.
Definitely! Good idea, here you go #58336
alexandre-daubois
approved these changes
Sep 20, 2024
fabpot
approved these changes
Sep 21, 2024
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #58238 on 6.4