8000 Make more data providers static by derrabus · Pull Request #58324 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make more data providers static #58324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Make more data providers static #58324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Process/Tests/ProcessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function testInvalidCommand(Process $process)
$this->assertSame('\\' === \DIRECTORY_SEPARATOR ? 1 : 127, $process->run());
}

public function invalidProcessProvider()
public static function invalidProcessProvider(): array
{
return [
[new Process(['invalid'])],
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,7 @@ public function testDenormalizeBooleanTypeWithFilterBool(array $data, ?bool $exp
$this->assertSame($expectedFoo, $dummy->foo);
}

public function provideDenormalizeWithFilterBoolData(): array
public static function provideDenormalizeWithFilterBoolData(): array
{
return [
[['foo' => 'true'], true],
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/TypeInfo/Tests/TypeResolver/ReflectionTypeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function testResolve(Type $expectedType, \ReflectionType $reflection, ?Ty
/**
* @return iterable<array{0: Type, 1: \ReflectionType, 2?: TypeContext}>
*/
public function resolveDataProvider(): iterable
public static function resolveDataProvider(): iterable
{
$typeContext = (new TypeContextFactory())->createFromClassName(ReflectionExtractableDummy::class);
$reflection = new \ReflectionClass(ReflectionExtractableDummy::class);
Expand Down Expand Up @@ -89,7 +89,7 @@ public function testCannotResolveClassKeywordsWithoutTypeContext(\ReflectionType
/**
* @return iterable<array{0: \ReflectionType}>
*/
public function classKeywordsTypesDataProvider(): iterable
public static function classKeywordsTypesDataProvider(): iterable
{
$reflection = new \ReflectionClass(ReflectionExtractableDummy::class);

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function __toString(): string
/**
* @return iterable<array{0: Type, 1: string, 2?: TypeContext}>
*/
public function resolveDataProvider(): iterable
public static function resolveDataProvider(): iterable
{
$typeContextFactory = new TypeContextFactory(new StringTypeResolver());

Expand Down
Loading
0