8000 Make more data providers static by derrabus · Pull Request #58323 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make more data providers static #58323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

Make more data providers static #58323

merged 1 commit into from
Sep 20, 2024

Conversation

derrabus
Copy link
Member
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues N/A
License MIT

Data providers must be public and static in PHPUnit 11.

@carsonbot carsonbot added this to the 6.4 milestone Sep 19, 2024
@derrabus derrabus mentioned this pull request Sep 19, 2024
Merged
@derrabus derrabus force-pushed the chore/static-data-providers branch from 4de90ef to 6d6955b Compare September 20, 2024 07:24
derrabus added a commit that referenced this pull request Sep 20, 2024
@derrabus
minor #58324 Make more data providers static (derrabus)
5c739b7 
This PR was merged into the 7.1 branch.

Discussion
----------

Make more data providers static

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | N/A
| License       | MIT

Follows #58323. This PR fixes all data providers that did not exist in 6.4 yet.

Commits
-------

6327224 Make more data providers static
@alexandre-daubois alexandre-daubois mentioned this pull request Sep 20, 2024
Merged
@derrabus derrabus force-pushed the chore/static-data-providers branch from 6d6955b to c0d5be6 Compare September 20, 2024 08:18
@derrabus derrabus merged commit 7e8c7d9 into symfony:6.4 Sep 20, 2024
9 of 10 checks passed
@derrabus derrabus deleted the chore/static-data-providers branch September 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@stof stof stof approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic w 6686 elcoMattic is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @GromNaN @stof @alexandre-daubois @carsonbot
0