8000 [HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called by shyim · Pull Request #58241 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called #58241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called #58241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[HttpKernel] allow narrow type of not nullable getResponse when hasRe… 
…sponse has been called
  • Loading branch information
@shyim @nicolas-grekas
shyim authored and nicolas-grekas committed Oct 9, 2024
commit 69f2f481484953aa128d8e7e1e7b152d7ee91562
2 changes: 2 additions & 0 deletions src/Symfony/Component/HttpKernel/Event/RequestEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ public function setResponse(Response $response): void

/**
* Returns whether a response was set.
*
* @psalm-assert-if-true !null $this->getResponse()
*/
public function hasResponse(): bool
{
Expand Down
Loading
0