10000 [Notifier] Deprecate sms77 Notifier bridge by MrYamous · Pull Request #58200 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Deprecate sms77 Notifier bridge #58200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

[Notifier] Deprecate sms77 Notifier bridge #58200

merged 1 commit into from
Mar 29, 2025

Conversation

MrYamous
Copy link
Contributor
@MrYamous MrYamous commented Sep 8, 2024 •
edited by OskarStark
Loading
Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? yes
Issues Following #52936
License MIT

#52936 introduced a new Seven.io bridge for Notifier component to replace sms77 but this one has not been deprecated

@MrYamous MrYamous requested a review from OskarStark as a code owner September 8, 2024 10:29
@carsonbot carsonbot added this to the 7.2 milestone Sep 8, 2024
@OskarStark
Copy link
Contributor

As far as I remember, we decided not to deprecate it, just mention the new bridge and exclude it from new releases.

Is that true @fabpot ?

@nicolas-grekas
Copy link
Member

we decided not to deprecate it

reading #52936, it looks like we decided to postpone the deprecation to another PR, so here we are, this PR looks legit to me

@MrYamous
Copy link
Contributor Author

Thanks for reviews ! I've applied suggested changes, and fix CS according to fabbot

@MrYamous MrYamous force-pushed the notifier/deprecate-sms77 branch from b78d314 to 9b95102 Compare October 6, 2024 04:43
@MrYamous
Copy link
Contributor Author
MrYamous commented Oct 6, 2024 •
edited
Loading

I think i'm up to date with requested changes, and rebased for pending conflicts

xabbuh
xabbuh reviewed Oct 6, 2024
View reviewed changes
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
fabpot
fabpot requested changes Jan 5, 2025
View reviewed changes
Copy link
Member
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing as we're still using some deprecated code somewhere without proper annotations. Can you have a look? Thank you.

@MrYamous MrYamous force-pushed the notifier/deprecate-sms77 branch from 1f3ab7a to 48d0437 Compare January 16, 2025 19:01
@MrYamous
Copy link
Contributor Author

Tests are failing as we're still using some deprecated code somewhere without proper annotations. Can you have a look? Thank you.

Thanks for reminding me this, I think it's better now :)

@fabpot
Copy link
Member
fabpot commented Jan 17, 2025

It looks like tests are still failing.

@OskarStark
Copy link
Contributor

@MrYamous up to finish this PR?

@MrYamous
Copy link
Contributor Author

@MrYamous up to finish this PR?

@OskarStark Yes i'm going to finish this PR

@MrYamous MrYamous force-pushed the notifier/deprecate-sms77 branch from 9bdd6ca to 7ea4279 Compare February 28, 2025 15:07
@MrYamous
Copy link
Contributor Author

I've made some changes and rebased, I'm not sure but fails seems unrelated

@fabpot fabpot force-pushed the notifier/deprecate-sms77 branch from 7ea4279 to 006ea39 Compare March 29, 2025 11:39
@fabpot
Copy link
Member
fabpot commented Mar 29, 2025

Thank you @MrYamous.

@fabpot fabpot merged commit 764fe52 into symfony:7.3 Mar 29, 2025
5 of 11 checks passed
@fabpot fabpot mentioned this pull request Mar 29, 2025
Closed
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@xabbuh xabbuh xabbuh left review comments

@chalasr chalasr chalasr left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Deprecation Notifier Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
8 participants
@MrYamous @OskarStark @nicolas-grekas @fabpot @stof @xabbuh @chalasr @carsonbot
0