10000 [Dotenv] [DebugCommang] Ensure console commands respect `dotenv_path` by scruwi · Pull Request #58159 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Dotenv] [DebugCommang] Ensure console commands respect dotenv_path #58159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Dotenv] [DebugCommang] Ensure console commands respect dotenv_path #58159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94a77b3
[Dotenv][DebugCommang]: Ensure console commands respect `dotenv_path`…
scruwi Sep 3, 2024
b66a4de
[Dotenv] Create tests to ensure that command will respect `dotenv_pat…
scruwi Sep 4, 2024
6255fb6
[Dotenv] fix: remove real composer.json from fixtures
scruwi Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Dotenv] fix: remove real composer.json from fixtures
  • Loading branch information
@scruwi
scruwi committed Sep 4, 2024
commit 6255fb65539fa712e849a9a08ae69a4edcd2c3c8
7 changes: 6 additions & 1 deletion src/Symfony/Component/Dotenv/Tests/Command/DebugCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,12 @@ public function testWarningOnPhpEnvFile()

public function testLoadEnvFilesFromSubdirectory()
{
$output = $this->executeCommand(__DIR__.'/Fixtures/Scenario4', 'dev', 'config/.env');
$projectDirectory = __DIR__.'/Fixtures/Scenario4';
file_put_contents($projectDirectory.'/composer.json', '{"extra":{"runtime":{"dotenv_path": "config/.env"}}}');

$output = $this->executeCommand($projectDirectory, 'dev', 'config/.env');

@unlink($projectDirectory.'/composer.json');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Why don't we store the composer.json file in the fixtures directory in the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it before, but some tests failed for some reason. Please look at the previous commmit.


// Scanned Files
$this->assertStringContainsString('⨯ config/.env.local.php', $output);
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Dotenv/Tests/Command/Fixtures/Scenario4/composer.json
View file
Open in desktop

This file was deleted.

0