10000 [Security][SecurityBundle] Add messages and score on votes by eltharin · Pull Request #58107 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security][SecurityBundle] Add messages and score on votes #58107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

[Security][SecurityBundle] Add messages and score on votes #58107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fbad275
vote scoring and messages
eltharin Aug 27, 2024
1caecb5
review corrections
eltharin Aug 27, 2024
0ca4e01
psalm correction
eltharin Aug 27, 2024
96e6193
acces is int not bool
eltharin Aug 29, 2024
2a903b3
changes from review
eltharin Sep 10, 2024
52a7ea3
vote object in voteEvent
eltharin Sep 15, 2024
f4c704d
nicolas_grekas review
eltharin Jan 9, 2025
7e49fca
remove BC break
eltharin Jan 10, 2025
a892246
fabbot
eltharin Jan 10, 2025
7abffb1
change tests
eltharin Jan 10, 2025
23a03e2
restart from 0
eltharin Feb 11, 2025
17cbdf8
voteevent
eltharin Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change tests
  • Loading branch information
@eltharin
eltharin committed Feb 10, 2025
commit 7abffb178561c93b8cd0bf4852fdf72e44cbe420
20 changes: 10 additions & 10 deletions ...nt/Security/Core/Tests/Authorization/TraceableAccessDecisionManagerWithVoteObjectTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ public static function provideObjectsAndLogs(): \Generator
['ATTRIBUTE_1'],
null,
[
[$voter1, VoterInterface::ACCESS_GRANTED],
[$voter2, VoterInterface::ACCESS_GRANTED],
[$voter1, new Vote(VoterInterface::ACCESS_GRANTED)],
[$voter2, new Vote(VoterInterface::ACCESS_GRANTED)],
],
$result,
];
Expand All @@ -85,15 +85,15 @@ public static function provideObjectsAndLogs(): \Generator
'object' => true,
'result' => $result = new AccessDecision(VoterInterface::ACCESS_DENIED),
'voterDetails' => [
['voter' => $voter1, 'attributes' => ['ATTRIBUTE_1', 'ATTRIBUTE_2'], 'vote' => new Vote(VoterInterface::ACCESS_ABSTAIN)],
['voter' => $voter1, 'attributes' => ['ATTRIBUTE_1', 'ATTRIBUTE_2'], 'vote' => VoterInterface::ACCESS_ABSTAIN],
['voter' => $voter2, 'attributes' => ['ATTRIBUTE_1', 'ATTRIBUTE_2'], 'vote' => new Vote(VoterInterface::ACCESS_GRANTED)],
],
]],
['ATTRIBUTE_1', 'ATTRIBUTE_2'],
true,
[
[$voter1, VoterInterface::ACCESS_ABSTAIN],
[$voter2, VoterInterface::ACCESS_GRANTED],
[$voter2, new Vote(VoterInterface::ACCESS_GRANTED)],
],
$result,
];
Expand All @@ -110,8 +110,8 @@ public static function provideObjectsAndLogs(): \Generator
[null],
'jolie string',
[
[$voter1, VoterInterface::ACCESS_ABSTAIN],
[$voter2, VoterInterface::ACCESS_DENIED],
[$voter1, new Vote(VoterInterface::ACCESS_ABSTAIN)],
[$voter2, new Vote(VoterInterface::ACCESS_DENIED)],
],
$result,
];
Expand Down Expand Up @@ -152,8 +152,8 @@ public static function provideObjectsAndLogs(): \Generator
['ATTRIBUTE_2'],
$x,
[
[$voter1, VoterInterface::ACCESS_ABSTAIN],
[$voter2, VoterInterface::ACCESS_ABSTAIN],
[$voter1, new Vote(VoterInterface::ACCESS_ABSTAIN)],
[$voter2, new Vote(VoterInterface::ACCESS_ABSTAIN)],
],
$result,
];
Expand All @@ -170,8 +170,8 @@ public static function provideObjectsAndLogs(): \Generator
[12.13],
new \stdClass(),
[
[$voter1, VoterInterface::ACCESS_DENIED],
[$voter2, VoterInterface::ACCESS_DENIED],
[$voter1, new Vote(VoterInterface::ACCESS_DENIED)],
[$voter2, new Vote(VoterInterface::ACCESS_DENIED)],
],
$result,
];
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Http/Tests/Firewall/SwitchUserListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public function testSwitchUserAlreadySwitched($accessDecisionManager, string $de
$this->request->query->set('_switch_user', 'kuba');

$targetsUser = $this->callback(fn ($user) => 'kuba' === $user->getUserIdentifier());
$this->accessDecisionManager->expects($this->once())
$accessDecisionManager->expects($this->once())
->method($decideFunction)->with(self::callback(function (TokenInterface $token) use ($originalToken, $tokenStorage) {
// the token storage should also contain the original token for voters depending on it
return $token === $originalToken && $tokenStorage->getToken() === $originalToken;
Expand Down
0