8000 String/fix english inflector for quorum by Dean151 · Pull Request #57874 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

String/fix english inflector for quorum #57874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

String/fix english inflector for quorum #57874

wants to merge 1 commit into from

Conversation

Dean151
Copy link
Contributor
@Dean151 Dean151 commented Jul 29, 2024 •
edited
Loading
Q A
Branch? 6.4 for features
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A
License MIT

When asking English Inflector the plural of Quorum, we get Quora instead of expected Quorums.

Also added the relevant test coverage for it.

@carsonbot carsonbot added this to the 7.2 milestone Jul 29, 2024
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "6.4 for features / 5.4, 6.4, 7.0, and 7.1 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@Dean151 Dean151 changed the base branch from 7.2 to 6.4 July 29, 2024 16:14
@Dean151 Dean151 closed this Jul 29, 2024
@Dean151
Copy link
Contributor Author
Dean151 commented Jul 29, 2024

Replaced by #57875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Dean151 @carsonbot
0