8000 [Validator] Add German translation for `WordCount` constraint by OskarStark · Pull Request #57720 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Add German translation for WordCount constraint #57720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Validator] Add German translation for WordCount constraint #57720

merged 1 commit into from
Jul 17, 2024

Conversation

OskarStark
Copy link
Contributor
@OskarStark OskarStark commented Jul 13, 2024 •
edited
Loading
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Needs

@OskarStark OskarStark requested a review from xabbuh July 13, 2024 08:07
@carsonbot carsonbot added this to the 5.4 milestone Jul 13, 2024
xabbuh
xabbuh requested changes Jul 15, 2024
View reviewed changes
Copy link
Member
@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57716 got some changes regarding pluralisation: #57716 (comment)

@alexandre-daubois
Copy link
Member

Thanks for this PR!

@OskarStark
Copy link
Contributor Author

Updated

@xabbuh I don't like the "lang sein." translation, WDYT?

@OskarStark OskarStark requested a review from xabbuh July 17, 2024 12:36
@xabbuh
Copy link
Member
xabbuh commented Jul 17, 2024

I have suggested something for the "min message". If you agree with it, the other message can probably be adapted accordingly.

@OskarStark OskarStark requested a review from xabbuh July 17, 2024 12:53
@xabbuh
Copy link
Member
xabbuh commented Jul 17, 2024

👍 but we should probably merge #57752 first

@fabpot
Copy link
Member
fabpot commented Jul 17, 2024

Thank you @OskarStark.

@fabpot fabpot merged commit 563f881 into symfony:5.4 Jul 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@OskarStark @alexandre-daubois @xabbuh @fabpot @carsonbot
0