8000 [String] test: kebab-case to snake_case by wmouwen · Pull Request #57628 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[String] test: kebab-case to snake_case #57628

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2024
Merged

[String] test: kebab-case to snake_case #57628

merged 1 commit into from
Jul 6, 2024

Conversation

wmouwen
Copy link
Contributor
@wmouwen wmouwen commented Jul 2, 2024 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes?
New feature? no
Deprecations? no
Issues -
License MIT

In Symfony 7.1.1, kebab-case strings casted to snake_case properly. The changes made in 7.1.2 broke this functionality and kept it kebab-case.

It would be nice to have a kebab-case test added to the list to clearly define the expected behavior.

Relates to: #57497, #57612, #57616

@carsonbot carsonbot added this to the 7.2 milestone Jul 2, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot

This comment was marked as outdated.

Sign in to view
@wmouwen wmouwen changed the base branch from 7.2 to 7.1 July 2, 2024 19:30
@OskarStark OskarStark modified the milestones: 7.2, 7.1 Jul 3, 2024
@wmouwen wmouwen force-pushed the test/kebab-case-to-snake-case branch from 1bf9a5f to a824811 Compare July 5, 2024 17:26
@wmouwen wmouwen force-pushed the test/kebab-case-to-snake-case branch from a824811 to a6d0f3b Compare July 5, 2024 17:27
@wmouwen wmouwen changed the base branch from 7.1 to 5.4 July 5, 2024 17:28
@wmouwen
Copy link
Contributor Author
wmouwen commented Jul 5, 2024

Included the testcase suggested by @xabbuh.

Rebased against and retargeted PR to Symfony 5.4 instead of 7.1.

@xabbuh xabbuh modified the milestones: 7.1, 5.4 Jul 6, 2024
@fabpot
Copy link
Member
fabpot commented Jul 6, 2024

Thank you @wmouwen.

@fabpot fabpot merged commit 737d519 into symfony:5.4 Jul 6, 2024
1 of 2 checks passed
@wmouwen wmouwen deleted the test/kebab-case-to-snake-case branch July 6, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed String
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@wmouwen @carsonbot @fabpot @xabbuh @OskarStark
0