8000 [TwigBridge] Remove random file name for `lint:twig` output in case of error by GromNaN · Pull Request #57608 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Remove random file name for lint:twig output in case of error #57608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[TwigBridge] Remove random file name for lint:twig output in case of error #57608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove random file name for lint:twig output in case of error 
Before: ERROR  in sf_6681e2dd64a2e2.02015003 (line -1)

After:   ERROR  in Standard Input (line -1)
  • Loading branch information
@GromNaN
GromNaN committed Jun 30, 2024
commit a97acbd423c01c71f2347930db497dbaf4217560
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Command/LintCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$this->format = $input->getOption('format') ?? (GithubActionReporter::isGithubActionEnvironment() ? 'github' : 'txt');

if (['-'] === $filenames) {
return $this->display($input, $output, $io, [$this->validate(file_get_contents('php://stdin'), uniqid('sf_', true))]);
return $this->display($input, $output, $io, [$this->validate(file_get_contents('php://stdin'), 'Standard Input')]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other alternatives would be php://stdin or just stdin instead, as we are already familiar with these stream abbreviations.

outputs e.g.

ERROR in php://stdin (line -1)
// or
ERROR in stdin (line -1)

Copy link
Member Author
@GromNaN GromNaN Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also aimed at front-end developers who only know Twig and not PHP. It could be more specific:

ERROR in Input Template (line -1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, I don't think it matters, there's only one linted template, so no doubt about it.

}

if (!$filenames) {
Expand Down
0