[Security] Change to BadCredentialsException when empty username / password
#57378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadCredentialsException when empty username / …BadCredentialsException when empty username / password
chalasr
approved these changes
Jun 12, 2024
xabbuh
approved these changes
Jun 12, 2024
|
Thank you @llupa! Fyi, we only flip the high deps test on the dev and x.4 branches. |
|
Thanks for the fix ❤️ |
Merged
bobvandevijver
added a commit
to bobvandevijver/symfony
that referenced
this pull request
Dec 3, 2024
This was referenced Dec 3, 2024
fabpot
added a commit
that referenced
this pull request
Dec 6, 2024
… item (bobvandevijver) This PR was merged into the 7.1 branch. Discussion ---------- [Security] Update incorrect form authenticator changelog item | Q | A | ------------- | --- | Branch? | 7.1 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | # <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Related to #53851, #57378 & #59079. ~~Whether or not this an actual CVE, I believe this should be removed from the changelog anyways as it does not throw a bad request anymore.~~ ~~If we do keep considering it a new feature, it should probably be changed to reflect the correct exception.~~ As discussed, now only an update to note the actual exception being thrown. Commits ------- 38f8ec2 Fix change log to mentioned thrown exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will likely fail since they are running flipped.