8000 [Validator] fix cssColor HSLA test dataProvider by sfmok · Pull Request #57352 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] fix cssColor HSLA test dataProvider #57352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2024
Merged

[Validator] fix cssColor HSLA test dataProvider #57352

merged 1 commit into from
Jun 9, 2024

Conversation

sfmok
Copy link
Contributor
@sfmok sfmok commented Jun 8, 2024
Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues Fix cssColor HSLA test dataProvider
License MIT

testInvalidHSLA refers to a wrong dataProvider method

@carsonbot carsonbot added this to the 7.2 milestone Jun 8, 2024
@carsonbot carsonbot changed the title fix cssColor HSLA test dataProvider [Validator] fix cssColor HSLA test dataProvider Jun 9, 2024
@fabpot fabpot changed the base branch from 7.2 to 5.4 June 9, 2024 06:54
@fabpot
Copy link
Member
fabpot commented Jun 9, 2024

Good catch, thanks @sfmok.

@fabpot fabpot merged commit ab461c5 into symfony:5.4 Jun 9, 2024
11 of 12 checks passed
@fabpot fabpot modified the milestones: 7.2, 5.4 Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sfmok @fabpot @OskarStark @carsonbot
0