8000 [Process] Regression: Error output-handling is affecting Drupal core development by TravisCarden · Pull Request #57317 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Process] Regression: Error output-handling is affecting Drupal core development #57317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Process] Regression: Error output-handling is affecting Drupal core development #57317

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
869daa4
Temporarily revert regression in \Symfony\Component\Process\Process::…
TravisCarden Jun 4, 2024
08d1522
Add regression test.
TravisCarden Jun 4, 2024
540f1dc
Put back regression in \Symfony\Component\Process\Process::start().
TravisCarden Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Temporarily revert regression in \Symfony\Component\Process\Process::… 
…start().
  • Loading branch information
@TravisCarden
TravisCarden committed Jun 4, 2024
commit 869daa4477487d4267f0a1b4aba2906e3583e5b8
12 changes: 6 additions & 6 deletions src/Symfony/Component/Process/Process.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,12 @@ public function start(?callable $callback = null, array $env = []): void
$env += '\\' === \DIRECTORY_SEPARATOR ? array_diff_ukey($this->getDefaultEnv(), $env, 'strcasecmp') : $this->getDefaultEnv();

if (\is_array($commandline = $this->commandline)) {
$commandline = array_values(array_map(strval(...), $commandline));
$commandline = implode(' ', array_map($this->escapeArgument(...), $commandline));

if ('\\' !== \DIRECTORY_SEPARATOR) {
// exec is mandatory to deal with sending a signal to the process
$commandline = 'exec '.$commandline;
}
} else {
$commandline = $this->replacePlaceholders($commandline, $env);
}
Expand All @@ -320,11 +325,6 @@ public function start(?callable $callback = null, array $env = []): void
// last exit code is output on the fourth pipe and caught to work around --enable-sigchild
$descriptors[3] = ['pipe', 'w'];

if (\is_array($commandline)) {
// exec is mandatory to deal with sending a signal to the process
$commandline = 'exec '.$this->buildShellCommandline($commandline);
}

// See https://unix.stackexchange.com/questions/71205/background-process-pipe-input
$commandline = '{ ('.$commandline.') <&3 3<&- 3>/dev/null & } 3<&0;';
$commandline .= 'pid=$!; echo $pid >&3; wait $pid 2>/dev/null; code=$?; echo $code >&3; exit $code';
Expand Down
0