8000 [Console] Add DialogHelper::askHiddenResponse method by romainneutron · Pull Request #5731 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add DialogHelper::askHiddenResponse method #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2012
Merged

[Console] Add DialogHelper::askHiddenResponse method #5731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e396edb
[Console] Add DialogHelper::askHiddenResponse method
romainneutron Oct 10, 2012
ac01d5d
Fix tests and CS
romainneutron Oct 11, 2012
e2eaf5a
Update Changelog, add Readme note about hidden input third party
romainneutron Oct 12, 2012
26c35e0
Skip askHiddenResponse test on windows
romainneutron Oct 13, 2012
c0f8a63
Fix CS and typos
romainneutron Oct 16, 2012
aefa495
Move `hiddeninput.exe` to Resources/bin
romainneutron Oct 16, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Changelog, add Readme note about hidden input third party
  • Loading branch information
@romainneutron
romainneutron committed Oct 15, 2012
commit e2eaf5a6d5cbe6290ef66caa9be6594137f1ba35
1 change: 1 addition & 0 deletions src/Symfony/Component/Console/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ CHANGELOG
-----

* added support for colorization on Windows via ConEmu
* add a method to Dialog Helper to ask for a question and hide the response

2.1.0
-----
Expand Down
8 changes: 7 additions & 1 deletion src/Symfony/Component/Console/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,18 @@ output abstractions (so that you can easily unit-test your commands),
validation, automatic help messages, ...

Tests
---------
-----

You can run the unit tests with the following command:

phpunit

Third Party
-----------

`hiddeninput.exe` third party binary is provided within this component. Find
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have stored the executable under a Resources/bin directory like done in some other components.

sources and license at https://github.com/Seldaek/hidden-input.

Resources
---------

Expand Down
0