8000 [PhpUnitBridge] Fix error handler triggered outside of tests by HypeMC · Pull Request #57110 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
/ symfony Public

[PhpUnitBridge] Fix error handler triggered outside of tests #57110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

[PhpUnitBridge] Fix error handler triggered outside of tests #57110

merged 1 commit into from
Jun 4, 2024

Conversation

HypeMC
Copy link
Contributor
@HypeMC HypeMC commented May 25, 2024
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #57071
License MIT

The error handler should be invoked only if the error occurred inside a test.

@HypeMC HypeMC mentioned this pull request May 25, 2024
Closed
@usu usu mentioned this pull request Jun 1, 2024
Closed
1 task
@shyim shyim mentioned this pull request Jun 3, 2024
Merged
@SpartakusMd
Copy link
Contributor

Tested the fix and confirm I can run the tests successfully.

@fabpot
Copy link
Member
fabpot commented Jun 4, 2024

Thank you @HypeMC.

@fabpot fabpot merged commit 8ed9bb0 into symfony:5.4 Jun 4, 2024
8 of 13 checks passed
@fabpot fabpot mentioned this pull request Jun 4, 2024
Merged
@HypeMC HypeMC deleted the fix-error-handler-triggered-outside-of-tests branch June 4, 2024 07:08
@HypeMC HypeMC mentioned this pull request Jun 14, 2024
Merged
fabpot added a commit that referenced this pull request Jun 15, 2024
@fabpot
minor #57403 [PhpUnitBridge] Add missing import (HypeMC)
1b55cec 
This PR was merged into the 5.4 branch.

Discussion
----------

[PhpUnitBridge] Add missing import

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Follow up to #57110, looks like I forgot to commit the use statement. 😞

Commits
-------

661e79a [PhpUnitBridge] Add missing import
This was referenced Jun 28, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HypeMC @SpartakusMd @fabpot @nicolas-grekas @chalasr @xabbuh @carsonbot
0