[Serializer] Fixed "Warning: Attempt to read property "value" on string" #54851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1.0-BETA1". Cheers! Carsonbot |
xabbuh
approved these changes
May 6, 2024
I'll try tomorrow. |
|
This is a reproduce code at the moment: |
|
@xabbuh I gave up. Could you help me ? |
58fccef to
eda1dfc
Compare
|
thanks for the snippet, I was able to create a test based on it 👍 |
eda1dfc to
975d64c
Compare
975d64c to
90251c9
Compare
|
Thank you @michaljusiega. |
|
Thank you too @xabbuh ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've updated my project to
7.1.0-BETA1and I found an error.After update I got:
Warning: Attempt to read property "value" on stringinvendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748because in733 linethe enum-case of valueTypeIdentifierhas been already readed.Quite not sure if tests are possible here.