[PropertyInfo] Fix PHPStan properties type in trait #54675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c628b73 to
0b1b275
Compare
stof
approved these changes
Apr 19, 2024
OskarStark
approved these changes
Apr 19, 2024
|
Thank you @mtarld. |
This was referenced Apr 29, 2024
Merged
Merged
Merged
|
This change caused some breakage for us (that was quickly resolved), so maybe someone else runs into a similar issue and finds this helpful: We had code that looked something like this: trait Foo {
public readonly array $items;
// some methods that do stuff on items to implement \Countable, \ArrayAccess, etc
}
final readonly class SomeList implements \Countable, \ArrayAccess {
use Foo;
public function __construct(
/** @var SomeItem[] */
#[SerializerName("SomeItem")]
public array $items;
) { }
}
final readonly class OtherList implements \Countable, \ArrayAccess {
use Foo;
public function __construct(
/** @var OtherItem[] */
#[SerializerName("OtherItemName")]
public array $items;
) { }
}I am unsure why the Obviously this change is correct and we gladly only hat one case where we relied on the old behaviour (by accident), so fixing it was easy. We just remove the property from the trait, the Phpstan extractor looked at the metadata of the constructor param instead of the trait property again, and tests went green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle traits properly in
PhpStanExtractor.