8000 [Validator] Fill in trans-unit id 113: This URL does not contain a TLD. by nicolas-grekas · Pull Request #54536 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Fill in trans-unit id 113: This URL does not contain a TLD. #54536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Apr 9, 2024
@nicolas-grekas nicolas-grekas force-pushed the trans-id-113 branch 7 times, most recently from 027943f to 2e01dc7 Compare April 9, 2024 19:28
@nicolas-grekas
Copy link
Member Author

PR should be ready. I used the .github/sync-translations.php script to create the tags for the new trans unit and asked GPT to generate translations (I made it generate a csv as output and I wrote a small script to populate the files).
I also fixed the CI job that was supposed to run when a translation file changes but didn't.

@thunderer
Copy link
Contributor

@nicolas-grekas will you merge #54522 before this one, or would you like me to rebase mine afterwards?

@nicolas-grekas nicolas-grekas force-pushed the trans-id-113 branch 3 times, most recently from fded2a6 to b57bf7a Compare April 10, 2024 09:16
@nicolas-grekas nicolas-grekas merged commit 886af6f into symfony:5.4 Apr 11, 2024
@nicolas-grekas nicolas-grekas deleted the trans-id-113 branch April 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0