8000 [Process] Don't call sigprocmask if there is no ignored signals by joelwurtz · Pull Request #54495 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Process] Don't call sigprocmask if there is no ignored signals #54495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

joelwurtz
Copy link
Contributor
Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

It seems that passing an empty signal list makes an error on php 8.4 see https://github.com/symfony/symfony/actions/runs/8566954369/job/23477741854

This should fix this case

@carsonbot carsonbot added this to the 7.1 milestone Apr 5, 2024
@joelwurtz joelwurtz force-pushed the fix/fix-signals-php84 branch 2 times, most recently from 6f9c6de to 9d269ea Compare April 5, 2024 09:07
@joelwurtz joelwurtz force-pushed the fix/fix-signals-php84 branch from 9d269ea to 3cf4e36 Compare April 5, 2024 09:28
@carsonbot carsonbot changed the title fix(process): don't call sigprocmask if there is no ignored signals [Process] fix(process): don't call sigprocmask if there is no ignored signals Apr 5, 2024
@nicolas-grekas nicolas-grekas changed the title [Process] fix(process): don't call sigprocmask if there is no ignored signals [Process] Don't call sigprocmask if there is no ignored signals Apr 5, 2024
@nicolas-grekas
Copy link
Member

Thank you @joelwurtz.

@nicolas-grekas nicolas-grekas merged commit fd1d19e into symfony:7.1 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0