8000 [Cache] synchronize Redis proxy traits for different versions by xabbuh · Pull Request #54410 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] synchronize Redis proxy traits for different versions #54410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

[Cache] synchronize Redis proxy traits for different versions #54410

merged 1 commit into from
Mar 27, 2024

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 26, 2024
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

see phpredis/phpredis#2471

@carsonbot carsonbot added this to the 6.4 milestone Mar 26, 2024
@xabbuh xabbuh force-pushed the cache-redis-sync branch from fc5ae53 to 538afaf Compare March 26, 2024 20:37
@xabbuh xabbuh changed the title sync Redis proxy [Cache] fix Redis 6 proxy test Mar 26, 2024
@xabbuh xabbuh force-pushed the cache-redis-sync branch 2 times, most recently from d0b5540 to 0a8b9e5 Compare March 26, 2024 21:15
@xabbuh xabbuh mentioned this pull request Mar 26, 2024
Closed
@xabbuh xabbuh force-pushed the cache-redis-sync branch from 0a8b9e5 to 9c1cfd6 Compare March 26, 2024 21:22
@xabbuh xabbuh requested review from nicolas-grekas and stof March 26, 2024 21:25
@xabbuh xabbuh force-pushed the cache-redis-sync branch from 9c1cfd6 to 2d11822 Compare March 26, 2024 21:27
@xabbuh xabbuh force-pushed the cache-redis-sync branch from 2d11822 to bc22326 Compare March 27, 2024 13:28
@xabbuh xabbuh changed the title [Cache] fix Redis 6 proxy test [Cache] synchronize Redis proxy traits for different versions Mar 27, 2024
@xabbuh xabbuh merged commit c556c10 into symfony:6.4 Mar 27, 2024
@xabbuh xabbuh deleted the cache-redis-sync branch March 27, 2024 19:40
@xabbuh xabbuh mentioned this pull request Apr 4, 2024
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 17, 2024
Merged
nicolas-grekas added a commit that referenced this pull request Apr 17, 2024
@nicolas-grekas
minor #54639 [Cache] Fix test failure related to Redis6Proxy on appve…
711cf7b 
…yor (nicolas-grekas)

This PR was merged into the 6.4 branch.

Discussion
----------

[Cache] Fix test failure related to Redis6Proxy on appveyor

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Partially reverting #54410 and changing our testing strategy: we test only with the released version of Redis 6 now (as we do for Redis 5).
The develop branch of phpredis will require a different proxy, but let's wait for a tag to adapt.

Commits
-------

9bfe076 [Cache] Fix test failure related to Redis6Proxy on appveyor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@xabbuh @carsonbot
0