8000 Make PasswordStrenghtValidator::estimateStrength public by bjorvack · Pull Request #54405 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Make PasswordStrenghtValidator::estimateStrength public #54405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bjorvack
Copy link
@bjorvack bjorvack commented Mar 26, 2024
Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

When implementing a password strength check in the frontend off an application duplicate code has to be made. By making the estimateStrength method public we can utilize the same logic/implementation as the backend validation.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Contributor
@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im wondering if the strenght value should be set as a violation parameter, so it can be obtained or used in translations using existing public API

@derrabus
Copy link
Member

Can you elaborate what kind of duplicate code you need to write currently because the method is not public? I'm not convinced yet, we need this change.


Generally speaking, the method was not intended to be a public API which is why it's just a private method on the validator. If we wanted to make is reusable, we should rather extract it into a separate service that can be consumed in userland as well.

Either way, we would need additional tests. Your change creates a new public API that is not covered by tests currently.

@xabbuh
Copy link
Member
xabbuh commented Apr 3, 2024

im wondering if the strenght value should be set as a violation parameter, so it can be obtained or used in translations using existing public API

good idea, see #54479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0