Make PasswordStrenghtValidator::estimateStrength public #54405
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Can you elaborate what kind of duplicate code you need to write currently because the method is not public? I'm not convinced yet, we need this change. Generally speaking, the method was not intended to be a public API which is why it's just a private method on the validator. If we wanted to make is reusable, we should rather extract it into a separate service that can be consumed in userland as well. Either way, we would need additional tests. Your change creates a new public API that is not covered by tests currently. |
good idea, see #54479 |
When implementing a password strength check in the frontend off an application duplicate code has to be made. By making the estimateStrength method public we can utilize the same logic/implementation as the backend validation.